Add optional 'daemon' parameter to fetch and fixed tests #2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
|
Sorry for the delay on this, I'm hoping I'll get time to take a look tonight :) |
Author
|
No problem. It's my second time creating a pull request so feel free to
give me any feedback.
Thanks.
…On Mon, Jan 30, 2017 at 6:16 AM Linus Unnebäck ***@***.***> wrote:
Sorry for the delay on this, I'm hoping I'll get time to take a look
tonight :)
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#2 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AGO7Pn1wvNm0bxfqlFKpyG09Q4I7uoNWks5rXdSWgaJpZM4LwPyv>
.
|
Owner
|
@aaronbc so sorry for never getting around to this 🙈 I just pushed some major updates, but if you are still interested in this it shouldn't be too hard to rebase. I think it would be nice to have it as an options object instead of just another parameter though, e.g. Is this only applicable to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.